Skip to content

feat: Add a column to workload indicating if it is finished#2615

Merged
k8s-ci-robot merged 2 commits into
kubernetes-sigs:mainfrom
highpon:feat/2609
Jul 16, 2024
Merged

feat: Add a column to workload indicating if it is finished#2615
k8s-ci-robot merged 2 commits into
kubernetes-sigs:mainfrom
highpon:feat/2609

Conversation

@highpon
Copy link
Copy Markdown
Member

@highpon highpon commented Jul 15, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

When retrieving information about workload resources via the kubectl get command, we are unable to determine whether the workload had completed. It would be more convenient to know if the workload had finished.

Which issue(s) this PR fixes:

Fixes #2609

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Add a column to workload indicating if it is finished

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 15, 2024
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jul 15, 2024

Hi @highpon. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 15, 2024
@netlify
Copy link
Copy Markdown

netlify Bot commented Jul 15, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 29706d8
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6695bd04712f970008c7e8d9

@alculquicondor
Copy link
Copy Markdown
Contributor

alculquicondor commented Jul 15, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 15, 2024
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jul 15, 2024

LGTM label has been added.

DetailsGit tree hash: 2c2e17682b1067991120190bd9bffa5f96cf2f22

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2024
@alculquicondor
Copy link
Copy Markdown
Contributor

alculquicondor commented Jul 15, 2024

/ok-to-test

I think you need to run make manifests update-helm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 15, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 16, 2024
tenzen-y
tenzen-y reviewed Jul 16, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 16, 2024
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jul 16, 2024

LGTM label has been added.

DetailsGit tree hash: 008138b3e8dc5f6a3feda61b8721080f7520453d

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jul 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, highpon, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [alculquicondor,tenzen-y]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5dde9fc into kubernetes-sigs:main Jul 16, 2024
@k8s-ci-robot k8s-ci-robot added this to the v0.8 milestone Jul 16, 2024
@highpon highpon deleted the feat/2609 branch July 16, 2024 00:42
@highpon highpon mentioned this pull request Jul 30, 2024
Closed
11 tasks
kannon92 pushed a commit to openshift-kannon92/kubernetes-sigs-kueue that referenced this pull request Nov 19, 2024
@highpon @kannon92
feat: Add a column to workload indicating if it is finished (kubernet…
5c5adad 
…es-sigs#2615)

* feat: Add a column to workload indicating if it is finished

* fix: update helm charts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tenzen-y tenzen-y tenzen-y left review comments

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

@trasc trasc Awaiting requested review from trasc

Assignees

@alculquicondor alculquicondor

@tenzen-y tenzen-y

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v0.8

Development

Successfully merging this pull request may close these issues.

Add a column to workload indicating if it is finished

4 participants

@highpon @k8s-ci-robot @alculquicondor @tenzen-y